2Shirt/WizardKit
2Shirt/WizardKit
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 26 Packages Wiki Activity Actions

Recheck disk attributes after all tests

Browse source 
* Should catch errors exposed by badblocks
* Addresses issue #96
This commit is contained in:
2Shirt 2019-03-11 13:25:12 -06:00
parent 7078efe9e7
commit 7701418e55
Signed by: 2Shirt
GPG key ID: 152FAC923B0E132C
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
.bin/Scripts/functions/hw_diags.py
View file

@ -997,6 +997,11 @@ def run_hw_tests(state):
# No devices available # No devices available
v['Objects'].append(TestObj(dev=None, label='')) v['Objects'].append(TestObj(dev=None, label=''))
v['Objects'][-1].update_status('N/A') v['Objects'][-1].update_status('N/A')
# Recheck attributes
if state.tests['NVMe / SMART']['Enabled']:
for test_obj in state.tests['NVMe / SMART']['Objects']:
run_nvme_smart_tests(state, test_obj, update_mode=True)
except GenericAbort: except GenericAbort:
# Cleanup # Cleanup
tmux_kill_pane(*state.panes.values()) tmux_kill_pane(*state.panes.values())
@ -1400,8 +1405,11 @@ def run_network_test():
pause('Press Enter to return to main menu... ') pause('Press Enter to return to main menu... ')
def run_nvme_smart_tests(state, test): def run_nvme_smart_tests(state, test, update_mode=False):
"""Run NVMe or SMART test for test.dev.""" """Run NVMe or SMART test for test.dev.
Update mode is used to refresh the attributes and recheck them.
(i.e. no self-test and don't disable other tests)"""
dev = test.dev dev = test.dev
# Bail early # Bail early
@ -1421,7 +1429,7 @@ def run_nvme_smart_tests(state, test):
TOP_PANE_TEXT, dev.description)) TOP_PANE_TEXT, dev.description))
# SMART short self-test # SMART short self-test
if dev.smart_attributes and not state.quick_mode: if dev.smart_attributes and not (state.quick_mode or update_mode):
run_smart_short_test(state, test) run_smart_short_test(state, test)
# Attribute check # Attribute check
@ -1455,7 +1463,7 @@ def run_nvme_smart_tests(state, test):
pass pass
# Disable other disk tests if necessary # Disable other disk tests if necessary
if test.failed: if test.failed and not update_mode:
for t in ['badblocks', 'I/O Benchmark']: for t in ['badblocks', 'I/O Benchmark']:
dev.disable_test(t, 'Denied') dev.disable_test(t, 'Denied')