Rework NVMe/SMART sections #96

Closed
opened 2019-03-05 17:21:30 -07:00 by 2Shirt · 1 comment
2Shirt commented 2019-03-05 17:21:30 -07:00 (Migrated from gitea.2shirt.work)

For easier implementation, include all disks in SMART short test but report 'N/A' for unsupported disks. Should simplify determining overall disk pass/fail status.

For easier implementation, include all disks in SMART short test but report 'N/A' for unsupported disks. Should simplify determining overall disk pass/fail status.
2Shirt commented 2019-03-09 15:42:59 -07:00 (Migrated from gitea.2shirt.work)

Separating the SMART short-test would work but isn't necessary. Instead check_attributes should be simplified so it can be called multiple times. It should only return a PASS/FAIL bool with no output.

The 199/C7 and override question should be moved into safety_check().

Separating the SMART short-test would work but isn't necessary. Instead check_attributes should be simplified so it can be called multiple times. It should only return a PASS/FAIL bool with no output. The 199/C7 and override question should be moved into safety_check().
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: 2Shirt/WizardKit#96
No description provided.