popen_program() causing crashes #27

New issue

Closed

opened 2018-05-12 15:23:51 -06:00 by 2Shirt · 0 comments

2Shirt commented

2018-05-12 15:23:51 -06:00

(Migrated from gitea.2shirt.work)

popen_program() can cause a Major exception if the cmd path is invalid or the program being pointed to is missing.

2018-05-10 1251-0700: Please let 2Shirt know by opening an issue on GitHub
2018-05-10 1251-0700: Traceback (most recent call last):
2018-05-10 1251-0700:   File "D:\1201 Toolbox\.bin\Scripts\system_checklist.py", line 90, in <module>
2018-05-10 1251-0700:     run_xmplay()
2018-05-10 1251-0700:   File "D:\1201 Toolbox\.bin\Scripts\functions\diags.py", line 69, in run_xmplay
2018-05-10 1251-0700:     popen_program(cmd)
2018-05-10 1251-0700:   File "D:\1201 Toolbox\.bin\Scripts\functions\common.py", line 372, in popen_program
2018-05-10 1251-0700:     popen_obj = subprocess.Popen(cmd, shell=shell, startupinfo=startupinfo)
2018-05-10 1251-0700:   File "subprocess.py", line 709, in __init__
2018-05-10 1251-0700:   File "subprocess.py", line 997, in _execute_child
2018-05-10 1251-0700: FileNotFoundError: [WinError 2] The system cannot find the file specified

There should be more exception handling to prevent full crashes

`popen_program()` can cause a Major exception if the cmd path is invalid or the program being pointed to is missing. ```2018-05-10 1251-0700: Major exception 2018-05-10 1251-0700: Please let 2Shirt know by opening an issue on GitHub 2018-05-10 1251-0700: Traceback (most recent call last): 2018-05-10 1251-0700: File "D:\1201 Toolbox\.bin\Scripts\system_checklist.py", line 90, in <module> 2018-05-10 1251-0700: run_xmplay() 2018-05-10 1251-0700: File "D:\1201 Toolbox\.bin\Scripts\functions\diags.py", line 69, in run_xmplay 2018-05-10 1251-0700: popen_program(cmd) 2018-05-10 1251-0700: File "D:\1201 Toolbox\.bin\Scripts\functions\common.py", line 372, in popen_program 2018-05-10 1251-0700: popen_obj = subprocess.Popen(cmd, shell=shell, startupinfo=startupinfo) 2018-05-10 1251-0700: File "subprocess.py", line 709, in __init__ 2018-05-10 1251-0700: File "subprocess.py", line 997, in _execute_child 2018-05-10 1251-0700: FileNotFoundError: [WinError 2] The system cannot find the file specified ``` There should be more exception handling to prevent full crashes