2Shirt/WizardKit
2Shirt/WizardKit
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 26 Packages Wiki Activity Actions

Verify destination FS is mounted read-write

Browse source
This commit is contained in:
2Shirt 2018-07-18 22:02:17 -06:00
parent f2c557f77c
commit e5ce254e8b
Signed by: 2Shirt
GPG key ID: 152FAC923B0E132C
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
.bin/Scripts/functions/ddrescue.py
View file

@ -73,7 +73,8 @@ def dest_safety_check(source, dest):
"""Verify the destination is appropriate for the source.""" """Verify the destination is appropriate for the source."""
source_size = source['Details']['size'] source_size = source['Details']['size']
if dest['Is Dir']: if dest['Is Dir']:
cmd = ['findmnt', '-D', '-J', cmd = ['findmnt', '-J',
'-o', 'SOURCE,TARGET,FSTYPE,OPTIONS,SIZE,AVAIL,USED',
'-T', dest['Path']] '-T', dest['Path']]
result = run_program(cmd) result = run_program(cmd)
try: try:
@ -86,6 +87,7 @@ def dest_safety_check(source, dest):
dest_size = json_data['filesystems'][0]['avail'] dest_size = json_data['filesystems'][0]['avail']
dest['Free Space'] = dest_size dest['Free Space'] = dest_size
dest['Filesystem'] = json_data['filesystems'][0]['fstype'] dest['Filesystem'] = json_data['filesystems'][0]['fstype']
dest['Mount options'] = json_data['filesystems'][0]['options']
else: else:
dest_size = dest['Details']['size'] dest_size = dest['Details']['size']
@ -114,18 +116,16 @@ def dest_safety_check(source, dest):
s_size = human_readable_size(source_size))) s_size = human_readable_size(source_size)))
abort_ddrescue_tui() abort_ddrescue_tui()
# Filesystem checks # Imaging specific checks
if source['Type'] == 'Image': if source['Type'] == 'Image':
# Filesystem Type # Filesystem Type
if dest['Filesystem'] not in AUTHORIZED_DEST_FSTYPES: if dest['Filesystem'] not in AUTHORIZED_DEST_FSTYPES:
print_error( print_error(
'Destination filesystem "{}" is not a recommended type.'.format( 'Destination filesystem "{}" is not a recommended type.'.format(
dest['Filesystem'])) dest['Filesystem']))
if not ask('Proceed anyways? (strongly discouraged by author)'): if not ask('Proceed anyways? (Strongly discouraged)'):
abort_ddrescue_tui() abort_ddrescue_tui()
# Read-Write access # Read-Write access
## Note: only checks path permissions, not mount options
## if the FS is RO then ddrescue will fail later
dest_ok = True dest_ok = True
dest_st_mode = os.stat(dest['Path']).st_mode dest_st_mode = os.stat(dest['Path']).st_mode
dest_ok = dest_ok and dest_st_mode & stat.S_IRUSR dest_ok = dest_ok and dest_st_mode & stat.S_IRUSR
@ -134,6 +134,12 @@ def dest_safety_check(source, dest):
if not dest_ok: if not dest_ok:
print_error('Destination is not writable, refusing to continue.') print_error('Destination is not writable, refusing to continue.')
abort_ddrescue_tui() abort_ddrescue_tui()
# Mount options check
if 'rw' not in dest['Mount options'].split(','):
print_error(
'Destination is not mounted read-write, refusing to continue.')
abort_ddrescue_tui()
def get_device_details(dev_path): def get_device_details(dev_path):
"""Get device details via lsblk, returns JSON dict.""" """Get device details via lsblk, returns JSON dict."""