Breaking updates to TryAndPrint()
* Removed print_return argument * Instead if the function returns data assume it should be printed * Added ability to override msg_good for a single run() call
This commit is contained in:
parent
9ee664bc2b
commit
972cb6fb66
1 changed files with 10 additions and 8 deletions
|
|
@ -482,7 +482,7 @@ class TryAndPrint():
|
||||||
|
|
||||||
def run(
|
def run(
|
||||||
self, message, function, *args,
|
self, message, function, *args,
|
||||||
catch_all=True, print_return=False, verbose=False, **kwargs):
|
catch_all=True, msg_good=None, verbose=False, **kwargs):
|
||||||
# pylint: disable=catching-non-exception
|
# pylint: disable=catching-non-exception
|
||||||
"""Run a function and print the results, returns results as dict.
|
"""Run a function and print the results, returns results as dict.
|
||||||
|
|
||||||
|
|
@ -490,9 +490,11 @@ class TryAndPrint():
|
||||||
Otherwise if an exception occurs that wasn't specified it will be
|
Otherwise if an exception occurs that wasn't specified it will be
|
||||||
re-raised.
|
re-raised.
|
||||||
|
|
||||||
If print_return is True then the output from the function will be used
|
If the function returns data it will be used instead of msg_good,
|
||||||
instead of msg_good, msg_bad, or exception text. The output should be
|
msg_bad, or exception text.
|
||||||
a list or a subprocess.CompletedProcess object.
|
The output should be a list or a subprocess.CompletedProcess object.
|
||||||
|
|
||||||
|
If msg_good is passed it will override self.msg_good for this call.
|
||||||
|
|
||||||
If verbose is True then exception names or messages will be used for
|
If verbose is True then exception names or messages will be used for
|
||||||
the result message. Otherwise it will simply be set to result_bad.
|
the result message. Otherwise it will simply be set to result_bad.
|
||||||
|
|
@ -503,9 +505,9 @@ class TryAndPrint():
|
||||||
LOG.debug('args: %s', args)
|
LOG.debug('args: %s', args)
|
||||||
LOG.debug('kwargs: %s', kwargs)
|
LOG.debug('kwargs: %s', kwargs)
|
||||||
LOG.debug(
|
LOG.debug(
|
||||||
'catch_all: %s, print_return: %s, verbose: %s',
|
'catch_all: %s, msg_good: %s, verbose: %s',
|
||||||
catch_all,
|
catch_all,
|
||||||
print_return,
|
msg_good,
|
||||||
verbose,
|
verbose,
|
||||||
)
|
)
|
||||||
f_exception = None
|
f_exception = None
|
||||||
|
|
@ -544,11 +546,11 @@ class TryAndPrint():
|
||||||
raise
|
raise
|
||||||
else:
|
else:
|
||||||
# Success
|
# Success
|
||||||
if print_return:
|
if output:
|
||||||
result_msg = self._format_function_output(output)
|
result_msg = self._format_function_output(output)
|
||||||
print(result_msg)
|
print(result_msg)
|
||||||
else:
|
else:
|
||||||
print_success(self.msg_good, log=False)
|
print_success(msg_good if msg_good else self.msg_good, log=False)
|
||||||
|
|
||||||
# Done
|
# Done
|
||||||
self._log_result(message, result_msg)
|
self._log_result(message, result_msg)
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue