From 815cfde84acc64a60458b70c4db19b95747f26cb Mon Sep 17 00:00:00 2001 From: 2Shirt <2xShirt@gmail.com> Date: Mon, 3 Jul 2023 20:16:37 -0700 Subject: [PATCH] Refactor check_mprime_results() to use sets --- scripts/wk/hw/cpu.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/wk/hw/cpu.py b/scripts/wk/hw/cpu.py index 23edadad..c28a6f67 100644 --- a/scripts/wk/hw/cpu.py +++ b/scripts/wk/hw/cpu.py @@ -83,8 +83,8 @@ def check_cooling_results(sensors, test_object) -> None: def check_mprime_results(test_obj, working_dir) -> None: """Check mprime log files and update test_obj.""" - passing_lines = {} - warning_lines = {} + passing_lines = set() + warning_lines = set() def _read_file(log_name) -> list[str]: """Read file and split into lines, returns list.""" @@ -102,7 +102,7 @@ def check_mprime_results(test_obj, working_dir) -> None: for line in _read_file('results.txt'): line = line.strip() if re.search(r'(error|fail)', line, re.IGNORECASE): - warning_lines[line] = None + warning_lines.add(line) # prime.log (check if passed) for line in _read_file('prime.log'): @@ -112,10 +112,10 @@ def check_mprime_results(test_obj, working_dir) -> None: if match: if int(match.group(2)) + int(match.group(3)) > 0: # Errors and/or warnings encountered - warning_lines[match.group(1).capitalize()] = None + warning_lines.add(match.group(1).capitalize()) else: # No errors/warnings - passing_lines[match.group(1).capitalize()] = None + passing_lines.add(match.group(1).capitalize()) # Update status if warning_lines: