From 710fcc29dca4e47f8e8e8006d8c97942c0c070b8 Mon Sep 17 00:00:00 2001
From: 2Shirt <2xShirt@gmail.com>
Date: Mon, 20 Jan 2020 18:31:29 -0700
Subject: [PATCH] Catch non-blocking SMART errors between tests

* This doesn't block further tests, just ensures Disk Attributes fails
---
 scripts/wk/hw/diags.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/wk/hw/diags.py b/scripts/wk/hw/diags.py
index 9925dd27..ff9c7a51 100644
--- a/scripts/wk/hw/diags.py
+++ b/scripts/wk/hw/diags.py
@@ -195,6 +195,11 @@ class State():
             disk.tests['Disk Self-Test'].report.append(
               std.color_string('Please manually review SMART data', 'YELLOW'),
               )
+      else:
+        # No blocking errors encountered, check for minor attribute failures
+        if not disk.check_attributes(only_blocking=False):
+          disk.tests['Disk Attributes'].failed = True
+          disk.tests['Disk Attributes'].set_status('Failed')
 
       # Disable tests if necessary
       if disable_tests: