From 6dde471bf50ca71723cce8bcc0d325d0214bc0e1 Mon Sep 17 00:00:00 2001 From: 2Shirt <2xShirt@gmail.com> Date: Wed, 5 Jul 2023 16:08:02 -0700 Subject: [PATCH] Don't disable Chrome notifications by default. Doing so can cause Chrome sync to break and need re-authentication. --- scripts/auto_setup.py | 1 + scripts/wk/setup/win.py | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/auto_setup.py b/scripts/auto_setup.py index c0d01c3a..827f78a8 100644 --- a/scripts/auto_setup.py +++ b/scripts/auto_setup.py @@ -46,6 +46,7 @@ BASE_MENUS = { 'Configure System': ( MenuEntry('Apply ITS Settings', 'auto_apply_its_settings', selected=False), MenuEntry('Open-Shell', 'auto_config_open_shell', selected=False), + MenuEntry('Disable Chrome Notifications', 'auto_disable_chrome_notifications', selected=False), MenuEntry('Disable Fast Startup', 'auto_disable_fast_startup', selected=False), MenuEntry('Disable Telemetry', 'auto_shutup_10'), MenuEntry('Enable BSoD MiniDumps', 'auto_enable_bsod_minidumps'), diff --git a/scripts/wk/setup/win.py b/scripts/wk/setup/win.py index 56b00448..f95d18eb 100644 --- a/scripts/wk/setup/win.py +++ b/scripts/wk/setup/win.py @@ -484,7 +484,6 @@ def auto_activate_windows() -> None: def auto_config_browsers() -> None: """Configure Browsers.""" prompt = ' Press Enter to continue...' - TRY_PRINT.run('Chrome Notifications...', disable_chrome_notifications) TRY_PRINT.run( 'uBlock Origin...', enable_ublock_origin, msg_good='STARTED', ) @@ -508,6 +507,12 @@ def auto_config_open_shell() -> None: TRY_PRINT.run('Open Shell...', config_open_shell) +def auto_disable_chrome_notifications(): + """Disable Chrome notifications. + + NOTE: This can cause Chrome Sync to be re-authenticated.""" + TRY_PRINT.run('Disable Chrome Notifications...', disable_chrome_notifications) + def auto_disable_fast_startup(): """Disable fast startup (i.e. Hiberboot).""" TRY_PRINT.run(