2Shirt/WizardKit
2Shirt/WizardKit
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 26 Packages Wiki Activity Actions

Disable benchmark tests on surface scan failures

Browse source
This commit is contained in:
2Shirt 2021-04-09 03:02:28 -06:00
parent b3a667641d
commit 66bf189e55
Signed by: 2Shirt
GPG key ID: 152FAC923B0E132C
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
scripts/wk/hw/diags.py
View file

@ -158,7 +158,7 @@ class State():
self.panes.pop(key) self.panes.pop(key)
def disk_safety_checks(self, prep=False, wait_for_self_tests=True): def disk_safety_checks(self, prep=False, wait_for_self_tests=True):
# pylint: disable=too-many-branches # pylint: disable=too-many-branches,too-many-statements
"""Run disk safety checks.""" """Run disk safety checks."""
self_tests_in_progress = False self_tests_in_progress = False
for disk in self.disks: for disk in self.disks:
@ -208,7 +208,8 @@ class State():
if ( if (
'Disk Attributes' in disk.tests 'Disk Attributes' in disk.tests
and not disk.tests['Disk Attributes'].failed and not disk.tests['Disk Attributes'].failed
and not disk.check_attributes(only_blocking=False)): and not disk.check_attributes(only_blocking=False)
):
# No blocking errors encountered, but found minor attribute failures # No blocking errors encountered, but found minor attribute failures
if not prep: if not prep:
# Mid-diag failure detected # Mid-diag failure detected
@ -220,6 +221,16 @@ class State():
disk.tests['Disk Attributes'].failed = True disk.tests['Disk Attributes'].failed = True
disk.tests['Disk Attributes'].set_status('Failed') disk.tests['Disk Attributes'].set_status('Failed')
# Check Surface Scan
if (
'Disk Surface Scan' in disk.tests
and disk.tests['Disk Surface Scan'].failed
and 'Disk I/O Benchmark' in disk.tests
):
# Disable I/O Benchmark test
disk.tests['Disk I/O Benchmark'].set_status('Skipped')
disk.tests['Disk I/O Benchmark'].disabled = True
# Disable tests if necessary # Disable tests if necessary
if disable_tests: if disable_tests:
disk.disable_disk_tests() disk.disable_disk_tests()