From 6167d0d78d5326f09aa8790ae348f1e01fca35e8 Mon Sep 17 00:00:00 2001 From: 2Shirt <2xShirt@gmail.com> Date: Thu, 5 Dec 2019 14:24:57 -0700 Subject: [PATCH] Get disk serial numbers under macOS --- scripts/wk/hw/obj.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/wk/hw/obj.py b/scripts/wk/hw/obj.py index 6cc8e3a5..87f72072 100644 --- a/scripts/wk/hw/obj.py +++ b/scripts/wk/hw/obj.py @@ -516,7 +516,7 @@ class Test(): self.label = label self.passed = False self.report = [] - self.status = '' + self.status = 'Pending' def set_status(self, status): """Update status string.""" @@ -590,10 +590,9 @@ def get_disk_details_macos(path): def get_disk_serial_macos(path): """Get disk serial using system_profiler, returns str.""" - serial = 'Unknown Serial' - # TODO: Make it real - str(path) - return serial + cmd = ['sudo', 'smartctl', '--info', '--json', path] + smart_info = get_json_from_command(cmd) + return smart_info.get('serial_number', 'Unknown Serial') def get_known_disk_attributes(model):